-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): only run interop tests on commits to master #5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we keep interop testing in PRs for branches that aren't forks? |
guillaumemichel
approved these changes
Sep 20, 2024
This will be dealt with in a follow up PR that isn't a fork |
jxs
added
send-it
trivial
Marks PRs which are considered trivial and don't need approval from another maintainer.
labels
Sep 20, 2024
🟠 Waiting for conditions to match
|
This was referenced Sep 24, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
## Description Follow up to #5604. Interop tests only work on the main `rust-libp2p` repo, and not on forks, because of the S3 cache (introduced in #5586). The interop tests currently don't run in the PRs, but they run after the PRs are merged to `master`. This PR is trying to run interop tests in PR that are branches of the main repo (not forks).
sdbondi
added a commit
to sdbondi/rust-libp2p
that referenced
this pull request
Nov 1, 2024
* master: (36 commits) chore: refactor ping tests (libp2p#5655) feat: refactor distributed-key-value-store example (libp2p#5652) chore(ci): address clippy beta lints (libp2p#5649) feat(gossipsub): apply `max_transmit_size` to the published message (libp2p#5642) feat(kad): add `Behavior::find_closest_local_peers()` (libp2p#5645) fix(swarm-test): set proper version (libp2p#5648) deps(ci): update cargo-semver-checks (libp2p#5647) chore: fix typo in comment (libp2p#5643) feat: make runtime features optional in swarm-test (libp2p#5551) deps: bump Swatinem/rust-cache from 2.7.3 to 2.7.5 (libp2p#5633) chore: update igd-next to 0.15.1 (libp2p#5625) fix(server): removing dependency on libp2p-lookup (libp2p#5610) refactor(examples): use tokio instead of async-std in relay-server (libp2p#5600) deps: update metrics example dependencies (libp2p#5617) chore: update interop test run condition (libp2p#5611) chore(autonat-v2): fix dial_back_to_non_libp2p test (libp2p#5621) fix(swarm): don't report `NewExternalAddrCandidate` if already confirmed (libp2p#5582) chore(ci): address beta clippy lints (libp2p#5606) fix(ci): address cargo-deny advisories (libp2p#5596) chore(ci): only run interop tests on commits to master (libp2p#5604) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is done as temporary measure to unblock PR merging as the CI is currently broken