Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): only run interop tests on commits to master #5604

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

jxs
Copy link
Member

@jxs jxs commented Sep 19, 2024

Description

This is done as temporary measure to unblock PR merging as the CI is currently broken

@guillaumemichel
Copy link
Contributor

Can we keep interop testing in PRs for branches that aren't forks?

@guillaumemichel
Copy link
Contributor

Can we keep interop testing in PRs for branches that aren't forks?

This will be dealt with in a follow up PR that isn't a fork

@jxs jxs added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Sep 20, 2024
@libp2p libp2p deleted a comment from mergify bot Sep 20, 2024
@jxs jxs merged commit fd4e1e1 into libp2p:master Sep 20, 2024
65 of 67 checks passed
Copy link
Contributor

mergify bot commented Sep 20, 2024

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Run transport interoperability tests (native)
        • check-skipped = Run transport interoperability tests (native)
        • check-success = Run transport interoperability tests (native)
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Run transport interoperability tests (chromium)
        • check-skipped = Run transport interoperability tests (chromium)
        • check-success = Run transport interoperability tests (chromium)
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success = Check rustdoc intra-doc links
        • check-neutral = Check rustdoc intra-doc links
        • check-skipped = Check rustdoc intra-doc links
      • any of: [🛡 GitHub branch protection]
        • check-success = rustfmt
        • check-neutral = rustfmt
        • check-skipped = rustfmt
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-metrics
        • check-neutral = Test libp2p-metrics
        • check-skipped = Test libp2p-metrics
      • any of: [🛡 GitHub branch protection]
        • check-success = Compile on x86_64-apple-darwin
        • check-neutral = Compile on x86_64-apple-darwin
        • check-skipped = Compile on x86_64-apple-darwin
      • any of: [🛡 GitHub branch protection]
        • check-success = Compile on x86_64-pc-windows-msvc
        • check-neutral = Compile on x86_64-pc-windows-msvc
        • check-skipped = Compile on x86_64-pc-windows-msvc
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-yamux
        • check-neutral = Test libp2p-yamux
        • check-skipped = Test libp2p-yamux
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-swarm
        • check-neutral = Test libp2p-swarm
        • check-skipped = Test libp2p-swarm
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-mdns
        • check-neutral = Test libp2p-mdns
        • check-skipped = Test libp2p-mdns
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-relay
        • check-neutral = Test libp2p-relay
        • check-skipped = Test libp2p-relay
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-uds
        • check-neutral = Test libp2p-uds
        • check-skipped = Test libp2p-uds
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-rendezvous
        • check-neutral = Test libp2p-rendezvous
        • check-skipped = Test libp2p-rendezvous
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p
        • check-neutral = Test libp2p
        • check-skipped = Test libp2p
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-noise
        • check-neutral = Test libp2p-noise
        • check-skipped = Test libp2p-noise
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-gossipsub
        • check-neutral = Test libp2p-gossipsub
        • check-skipped = Test libp2p-gossipsub
      • any of: [🛡 GitHub branch protection]
        • check-success = Test rw-stream-sink
        • check-neutral = Test rw-stream-sink
        • check-skipped = Test rw-stream-sink
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-dns
        • check-neutral = Test libp2p-dns
        • check-skipped = Test libp2p-dns
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-floodsub
        • check-neutral = Test libp2p-floodsub
        • check-skipped = Test libp2p-floodsub
      • any of: [🛡 GitHub branch protection]
        • check-success = Compile with select features (mdns tcp dns async-std)
        • check-neutral = Compile with select features (mdns tcp dns async-std)
        • check-skipped = Compile with select features (mdns tcp dns async-std)
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-swarm-derive
        • check-neutral = Test libp2p-swarm-derive
        • check-skipped = Test libp2p-swarm-derive
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-pnet
        • check-neutral = Test libp2p-pnet
        • check-skipped = Test libp2p-pnet
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-tls
        • check-neutral = Test libp2p-tls
        • check-skipped = Test libp2p-tls
      • any of: [🛡 GitHub branch protection]
        • check-success = Compile on wasm32-wasi
        • check-neutral = Compile on wasm32-wasi
        • check-skipped = Compile on wasm32-wasi
      • any of: [🛡 GitHub branch protection]
        • check-success = Test multistream-select
        • check-neutral = Test multistream-select
        • check-skipped = Test multistream-select
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-kad
        • check-neutral = Test libp2p-kad
        • check-skipped = Test libp2p-kad
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-core
        • check-neutral = Test libp2p-core
        • check-skipped = Test libp2p-core
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-tcp
        • check-neutral = Test libp2p-tcp
        • check-skipped = Test libp2p-tcp
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-websocket
        • check-neutral = Test libp2p-websocket
        • check-skipped = Test libp2p-websocket
      • any of: [🛡 GitHub branch protection]
        • check-success = IPFS Integration tests
        • check-neutral = IPFS Integration tests
        • check-skipped = IPFS Integration tests
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-identify
        • check-neutral = Test libp2p-identify
        • check-skipped = Test libp2p-identify
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-dcutr
        • check-neutral = Test libp2p-dcutr
        • check-skipped = Test libp2p-dcutr
      • any of: [🛡 GitHub branch protection]
        • check-success = Compile on wasm32-unknown-emscripten
        • check-neutral = Compile on wasm32-unknown-emscripten
        • check-skipped = Compile on wasm32-unknown-emscripten
      • any of: [🛡 GitHub branch protection]
        • check-success = Compile with select features (mdns tcp dns tokio)
        • check-neutral = Compile with select features (mdns tcp dns tokio)
        • check-skipped = Compile with select features (mdns tcp dns tokio)
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-request-response
        • check-neutral = Test libp2p-request-response
        • check-skipped = Test libp2p-request-response
      • any of: [🛡 GitHub branch protection]
        • check-success = Compile on wasm32-unknown-unknown
        • check-neutral = Compile on wasm32-unknown-unknown
        • check-skipped = Compile on wasm32-unknown-unknown
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-mplex
        • check-neutral = Test libp2p-mplex
        • check-skipped = Test libp2p-mplex
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-ping
        • check-neutral = Test libp2p-ping
        • check-skipped = Test libp2p-ping
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-plaintext
        • check-neutral = Test libp2p-plaintext
        • check-skipped = Test libp2p-plaintext
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-autonat
        • check-neutral = Test libp2p-autonat
        • check-skipped = Test libp2p-autonat
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-quic
        • check-neutral = Test libp2p-quic
        • check-skipped = Test libp2p-quic
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-webrtc
        • check-neutral = Test libp2p-webrtc
        • check-skipped = Test libp2p-webrtc
      • any of: [🛡 GitHub branch protection]
        • check-success = Test quick-protobuf-codec
        • check-neutral = Test quick-protobuf-codec
        • check-skipped = Test quick-protobuf-codec
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-identity
        • check-neutral = Test libp2p-identity
        • check-skipped = Test libp2p-identity
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-allow-block-list
        • check-neutral = Test libp2p-allow-block-list
        • check-skipped = Test libp2p-allow-block-list
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-swarm-test
        • check-neutral = Test libp2p-swarm-test
        • check-skipped = Test libp2p-swarm-test
      • any of: [🛡 GitHub branch protection]
        • check-success = Check for changes in proto files
        • check-neutral = Check for changes in proto files
        • check-skipped = Check for changes in proto files
      • any of: [🛡 GitHub branch protection]
        • check-success = Ensure that Cargo.lock is up-to-date
        • check-neutral = Ensure that Cargo.lock is up-to-date
        • check-skipped = Ensure that Cargo.lock is up-to-date
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-connection-limits
        • check-neutral = Test libp2p-connection-limits
        • check-skipped = Test libp2p-connection-limits
      • any of: [🛡 GitHub branch protection]
        • check-success = examples
        • check-neutral = examples
        • check-skipped = examples
      • any of: [🛡 GitHub branch protection]
        • check-success = Run all WASM tests
        • check-neutral = Run all WASM tests
        • check-skipped = Run all WASM tests
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-memory-connection-limits
        • check-neutral = Test libp2p-memory-connection-limits
        • check-skipped = Test libp2p-memory-connection-limits
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-webtransport-websys
        • check-neutral = Test libp2p-webtransport-websys
        • check-skipped = Test libp2p-webtransport-websys
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-perf
        • check-neutral = Test libp2p-perf
        • check-skipped = Test libp2p-perf
      • any of: [🛡 GitHub branch protection]
        • check-success = Compile with MSRV
        • check-neutral = Compile with MSRV
        • check-skipped = Compile with MSRV
      • any of: [🛡 GitHub branch protection]
        • check-success = manifest_lint
        • check-neutral = manifest_lint
        • check-skipped = manifest_lint
      • any of: [🛡 GitHub branch protection]
        • check-success = Test libp2p-server
        • check-neutral = Test libp2p-server
        • check-skipped = Test libp2p-server
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

mergify bot pushed a commit that referenced this pull request Oct 4, 2024
## Description

Follow up to #5604. Interop
tests only work on the main `rust-libp2p` repo, and not on forks,
because of the S3 cache (introduced in
#5586).

The interop tests currently don't run in the PRs, but they run after the
PRs are merged to `master`. This PR is trying to run interop tests in PR
that are branches of the main repo (not forks).
sdbondi added a commit to sdbondi/rust-libp2p that referenced this pull request Nov 1, 2024
* master: (36 commits)
  chore: refactor ping tests (libp2p#5655)
  feat: refactor distributed-key-value-store example (libp2p#5652)
  chore(ci): address clippy beta lints (libp2p#5649)
  feat(gossipsub): apply `max_transmit_size` to the published message (libp2p#5642)
  feat(kad): add `Behavior::find_closest_local_peers()` (libp2p#5645)
  fix(swarm-test): set proper version (libp2p#5648)
  deps(ci): update cargo-semver-checks (libp2p#5647)
  chore: fix typo in comment (libp2p#5643)
  feat: make runtime features optional in swarm-test (libp2p#5551)
  deps: bump Swatinem/rust-cache from 2.7.3 to 2.7.5 (libp2p#5633)
  chore: update igd-next to 0.15.1 (libp2p#5625)
  fix(server): removing dependency on libp2p-lookup (libp2p#5610)
  refactor(examples): use tokio instead of async-std in relay-server (libp2p#5600)
  deps: update metrics example dependencies (libp2p#5617)
  chore: update interop test run condition (libp2p#5611)
  chore(autonat-v2): fix dial_back_to_non_libp2p test (libp2p#5621)
  fix(swarm): don't report `NewExternalAddrCandidate` if already confirmed (libp2p#5582)
  chore(ci): address beta clippy lints (libp2p#5606)
  fix(ci): address cargo-deny advisories (libp2p#5596)
  chore(ci): only run interop tests on commits to master (libp2p#5604)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants